Move fail point structs to an internal package. #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move the
mtest.FailPointstruct and the associated structs to a new internal packageinternal/failpoint.Background & Motivation
Most fail points in Go Driver integration tests are defined using the
mtest.FailPointtype. However, some integration tests, likeTestConvenientTransactions, cannot usemtestbecause it creates an import cycle. We can move theFailPointand associated structs to a separate internal package, allowing them to be used in any test package in the driver.Note that the
SetFailPointfunction is intentionally not moved to theinternal/failpointpackage because that would require importing themongopackage, causing an import cycle in some cases.