Skip to content

Commit

Permalink
Fix pom scope for Scala projects (#1531)
Browse files Browse the repository at this point in the history
Required the `api` dependency method from the `java-library` plugin.
Now the scope is `compile` (api) instead of `runtime` (implementation).

JAVA-5647
  • Loading branch information
rozza committed Oct 17, 2024
1 parent 8e83b62 commit ca1f66c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion bson-scala/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ description = "A Scala wrapper / extension to the bson library"
archivesBaseName = 'mongo-scala-bson'

dependencies {
implementation project(path: ':bson', configuration: 'default')
api project(path: ':bson', configuration: 'default')
}

sourceSets {
Expand Down
5 changes: 3 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,16 @@ configure(javaProjects) {

configure(scalaProjects) {
apply plugin: 'scala'
apply plugin: 'java-library'
apply plugin: 'idea'
apply plugin: "com.adtran.scala-multiversion-plugin"
apply plugin: "com.diffplug.spotless"

group = 'org.mongodb.scala'

dependencies {
implementation ('org.scala-lang:scala-library:%scala-version%')
implementation ('org.scala-lang:scala-reflect:%scala-version%')
api ('org.scala-lang:scala-library:%scala-version%')
api ('org.scala-lang:scala-reflect:%scala-version%')

testImplementation(platform("org.junit:junit-bom:$junitBomVersion"))
testImplementation("org.junit.vintage:junit-vintage-engine")
Expand Down
4 changes: 2 additions & 2 deletions driver-scala/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ archivesBaseName = 'mongo-scala-driver'


dependencies {
implementation project(path: ':bson-scala', configuration: 'default')
implementation project(path: ':driver-reactive-streams', configuration: 'default')
api project(path: ':bson-scala', configuration: 'default')
api project(path: ':driver-reactive-streams', configuration: 'default')
compileOnly 'com.google.code.findbugs:jsr305:1.3.9'

testImplementation project(':driver-sync')
Expand Down

0 comments on commit ca1f66c

Please sign in to comment.