Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QueryBatchCursor.ResourceManager.close (#1440) #1491

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

stIncMale
Copy link
Member

This is a backport of #1440 to 4.11.x.

JAVA-5516

@stIncMale stIncMale self-assigned this Sep 4, 2024
try (QueryBatchCursor<BsonDocument> cursor = new QueryBatchCursor<>(
new QueryResult<>(null, emptyList(), 0, serverAddress),
1, 1, new BsonDocumentCodec())) {
QueryBatchCursor<?>.ResourceManager cursorResourceManager = cursor.new ResourceManager(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot this syntax and had to Google it. I guess, I don't know Java :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not alone :)

Copy link
Member

@vbabanin vbabanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for handling the backport. Appreciate the swift action!

NOTE: I rerun the failed tests, let's wait until they are green.

@stIncMale stIncMale merged commit 4df153a into mongodb:4.11.x Sep 4, 2024
56 of 58 checks passed
@stIncMale stIncMale deleted the backport_JAVA-5516_to_4.11.x branch September 4, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants