Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: bump derive_more to 1.0 #1185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

minor: bump derive_more to 1.0 #1185

wants to merge 1 commit into from

Conversation

jayvdb
Copy link

@jayvdb jayvdb commented Aug 16, 2024

No description provided.

@isabelatkinson isabelatkinson self-requested a review August 16, 2024 15:28
@isabelatkinson
Copy link
Contributor

isabelatkinson commented Aug 16, 2024 •
edited
Loading

Hi @jayvdb, thanks for creating this pull request! derive_more's MSRV for 1.0 is 1.75, which is quite a bit higher than our current MSRV of 1.67. Do you have an immediate need for these changes? If not, I'd prefer to wait until our MSRV is compatible.

@jayvdb
Copy link
Author

jayvdb commented Aug 16, 2024

No immediate need. Happy for this to be put on ice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelatkinson isabelatkinson Awaiting requested review from isabelatkinson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayvdb @isabelatkinson