CLOUDP-228587: Migrate Maintenance Window #1880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roothorp
requested review from
helderjs,
s-urbaniak,
josvazg and
igor-karpukhin
roothorp
had a problem deploying
to
openshift-test
GitHub Actions
Error
roothorp
temporarily deployed
to
openshift-test
GitHub Actions
Inactive
josvazg
reviewed
Oct 23, 2024
Comment on lines
+12
to
+14
| type MaintenanceWindow struct { | ||
| *project.MaintenanceWindow | ||
| } |
There was a problem hiding this comment.
Why do we need the wrapping if we are not adding more fields?
There was a problem hiding this comment.
Honestly I was just following the layout of previous translation layers - however I was considering including the projectID in this struct rather than having to pass it down every time. Does that sound like a good idea?
josvazg
reviewed
Oct 23, 2024
Comment on lines
+16
to
+22
| func NewMaintenanceWindow(spec *project.MaintenanceWindow) *MaintenanceWindow { | ||
| if spec == nil { | ||
| return nil | ||
| } | ||
| // No slices so no normalization needed | ||
| return &MaintenanceWindow{MaintenanceWindow: spec} | ||
| } |
There was a problem hiding this comment.
Without the wrapping we would also not need this.
josvazg
reviewed
Oct 23, 2024
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestRoundtrip_MaintenanceWindow(t *testing.T) { |
There was a problem hiding this comment.
FYI gofuzz supports integration with dvyukovgo-fuzz which in turns means we might be able to make our fuzz tests official go fuzz tests, with the language support that this brings.
No need to change for this one, but maybe we could explore it going forward.
josvazg
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).