Fix LearnBoost/mongoose#2313: don't let user accidentally clobber geoNear params #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look at it tomorrow have to finish the refactoring first but nearly done |
|
needs to be against master branch |
|
manually merged for 2.0 |
|
Thanks Christian |
christkv
added a commit
that referenced
this pull request
Nov 14, 2014
|
merged manually into master (1.4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Christian,
A mongoose user ran into a fairly interesting issue - looks like you can clobber geoNear params by passing bad options to the
geoNear()function. Obviously, specifying ageoNearoption when callinggeoNear()isn't necessary or useful, but would be nice to foolproof this a bit more. One user's been having some trouble with this, and you can easily imagine a case where somebody might want to doif (options.geoNear) { collection.geoNear(x, y, options) }