fix: tests using lib prohibited #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
Nov 18, 2020
| @@ -29,6 +29,9 @@ | |||
| "jsdoc/require-returns-type": "off", | |||
| "jsdoc/valid-types": "off", | |||
|
|
|||
| // Since we use ts-node we should always require the TS code | |||
| "no-restricted-modules": ["error", { "patterns": ["**/../lib/**"] }], | |||
There was a problem hiding this comment.
The pattern is ../lib otherwise it matched a mocha/lib and bson/lib import we use
mbroadst
approved these changes
Nov 19, 2020
emadum
approved these changes
Nov 19, 2020
nbbeeken
force-pushed
the
chore/test-import-from-lib-fix
branch
from
9aca28c
to
dda57ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our tests was using lib which stops the tests from running if you have a clean repo, this little fix changes the import and adds a linter rule to catch this for us going forward.