Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: conform CRUD result types to specification #2651

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

mbroadst
Copy link
Member

@mbroadst mbroadst commented Dec 1, 2020

Our CRUD result types have been out-of-sync with the official drivers CRUD specification for some time. This patch brings them in line, and updates our tests accordingly

NODE-2936

Our CRUD result types have been out-of-sync with the official
drivers CRUD specification for some time. This patch brings them
in line, and updates our tests accordingly

NODE-2936
@mbroadst mbroadst force-pushed the NODE-2936/crud-result-conformance branch from b7b8b18 to b170ab1 Compare December 1, 2020 21:47
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍

src/bulk/common.ts Show resolved Hide resolved
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some Qs

src/bulk/common.ts Show resolved Hide resolved
src/operations/insert.ts Outdated Show resolved Hide resolved
src/operations/insert.ts Outdated Show resolved Hide resolved
@mbroadst mbroadst merged commit 0135e9e into master Dec 4, 2020
@mbroadst mbroadst deleted the NODE-2936/crud-result-conformance branch December 4, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants