Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-3291)!: Standardize error representation in the driver #2824

Merged
merged 37 commits into from
Jun 10, 2021
Merged

refactor(NODE-3291)!: Standardize error representation in the driver #2824

merged 37 commits into from
Jun 10, 2021

Commits on Jun 8, 2021

  1. refactor: Replace TypeError with MongoParseError when validating conn… 

    …ection options
    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    828ee8c View commit details
    Browse the repository at this point in the history

  2. fix: Better stack traces for change stream errors

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    7ef5b6a View commit details
    Browse the repository at this point in the history

  3. refactor: Change all driver errors to MongoError or subclass

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    92193d7 View commit details
    Browse the repository at this point in the history

  4. refactor: convert more errors to specific types

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    70cab37 View commit details
    Browse the repository at this point in the history

  5. refactor: eliminate more error edge cases

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    61735db View commit details
    Browse the repository at this point in the history

  6. test: fix expected message

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4d0c6b0 View commit details
    Browse the repository at this point in the history

  7. Add MongoDriverError and MongoServerError to exports

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    67d6401 View commit details
    Browse the repository at this point in the history

  8. Keep MongoError for debugging

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    6741b55 View commit details
    Browse the repository at this point in the history

  9. remove unnecessary call to capture stack trace

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    cccb211 View commit details
    Browse the repository at this point in the history

  10. Add sanity check code for MongoDriverError

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4dffb45 View commit details
    Browse the repository at this point in the history

  11. Make MongoParseError extend MongoDriverError

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    5c99ad8 View commit details
    Browse the repository at this point in the history

  12. Remove leftover driver error opts

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    7093af5 View commit details
    Browse the repository at this point in the history

  13. Add sanity check for findOne operation error handler

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4fb29eb View commit details
    Browse the repository at this point in the history

  14. Add sanity check to rename collection error handler

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    70c1505 View commit details
    Browse the repository at this point in the history

  15. Remove unnecessary wrapping of message parse errors

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    754b12f View commit details
    Browse the repository at this point in the history

  16. Update cmap errors to extend MongoDriverError instead of MongoError

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    189be89 View commit details
    Browse the repository at this point in the history

  17. Add MongoSystemError type

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2139c46 View commit details
    Browse the repository at this point in the history

  18. Make MongoWriteConcernError extend MongoServerError

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    a90cfbd View commit details
    Browse the repository at this point in the history

  19. Flatten MongoError class logic

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    6859329 View commit details
    Browse the repository at this point in the history

  20. Refine error types

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f7c15df View commit details
    Browse the repository at this point in the history

  21. Simplify unrecoverable error logic

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    796a2a4 View commit details
    Browse the repository at this point in the history

  22. Remove deprecated MongoError.create method

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    14eae5d View commit details
    Browse the repository at this point in the history

  23. Use more precise error type for server and topology descriptions

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    aa6e4f9 View commit details
    Browse the repository at this point in the history

  24. Remove test sanity check code

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    57a2808 View commit details
    Browse the repository at this point in the history

  25. Remove extra wrapping of errors in listIndex toArray as those errors … 

    …should already be processed
    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    49f3210 View commit details
    Browse the repository at this point in the history

  26. Use shared code to set errorLabels on MongoWriteConcernError

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    2101fa0 View commit details
    Browse the repository at this point in the history

  27. Fix incorrect message type in MongoWriteConcernError

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    b3e32c9 View commit details
    Browse the repository at this point in the history

  28. Move server error parsing logic to MongoServerError class

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    27ff6db View commit details
    Browse the repository at this point in the history

  29. Update spec test mock

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    235525b View commit details
    Browse the repository at this point in the history

  30. Fix errors test

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    99e2ecc View commit details
    Browse the repository at this point in the history

  31. Move codeName to be property on MongoServerError only

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    953dfb4 View commit details
    Browse the repository at this point in the history

  32. Move writeConcernError property to be only on MongoServerError

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    3d1c540 View commit details
    Browse the repository at this point in the history

  33. Apply correct types to error codes

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e409b78 View commit details
    Browse the repository at this point in the history

  34. Remove as any from gridfs download error

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    a998b92 View commit details
    Browse the repository at this point in the history

  35. Clean up error type use

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    e0bb546 View commit details
    Browse the repository at this point in the history

  36. Remove unused string option to MongoServerError constructor

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    cc145dd View commit details
    Browse the repository at this point in the history

  37. code review feedback

    @dariakp
    dariakp committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ed91110 View commit details
    Browse the repository at this point in the history