fix(NODE-3843): make GridFSBucketWriteStream.prototype.end() return this for compat with community nodejs types

[vkarpov15]

Description

Currently GridFSBucketWriteStream.prototype.end() returns void. https://github.com/DefinitelyTyped/DefinitelyTyped/pull/57473/files changed it so that end() now must return this, which means Mongoose and the Node driver are now incompatible with @types/[email protected]. First noticed this here

What is changing?

See above

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Compilation fails with @types/[email protected]. I took a look and it looks like this change compiles fine with @types/[email protected] as well.

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[marek-benes]

Please do review it and publish a new version. Affected projects are broken.

[baileympearson]

Thanks for submitting this change!

This looks good to me. I'll bring it to the team's attention for a second review and hopefully we can get a solution out in a timely manner.

[baileympearson]

Our plan is to release these changes in our next minor release, which we're targeting for Thursday. I'm going to go ahead and merge this into main but we can continue the conversation here as needed.

In the meantime, would pinning the version of @node/types to an older version work as a temporary solution?
@vkarpov15 @marek-benes

[vkarpov15]

@baileympearson we pinned @types/node to < 17.0.6 in Mongoose, so I think it should work if this project pins in the meantime as well

[Fazatholomew]

@baileympearson I can confirm that on my NestJS project which uses Mongoose 6.1.4, only <16.11.7 works. @types/node 17x has the problem