Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4650): handle handshake errors with SDAM #3426

Merged
merged 7 commits into from
Sep 29, 2022
Merged

feat(NODE-4650): handle handshake errors with SDAM #3426

merged 7 commits into from
Sep 29, 2022

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Sep 28, 2022 •
edited
Loading

Description

NODE-4650/NODE-3135

What is changing?

  • Updating SDAM handleError logic to handle auth handshake errors according to the spec
  • Unskipping the corresponding SDAM auth tests
  • New unit tests just for the new portions of the handleError logic
  • Injecting a new error connectionGeneration property when createConnection receives an error so that it can be checked for staleness even in the absence of a connection (which makes this a feat:)
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Spec compliance

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp changed the title fix(NODE-4650): handle handshake errors with SDAM feat(NODE-4650): handle handshake errors with SDAM Sep 28, 2022
@nbbeeken nbbeeken self-requested a review September 28, 2022 19:07
@dariakp dariakp marked this pull request as ready for review September 28, 2022 19:11
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 28, 2022
@dariakp dariakp force-pushed the NODE-4650/handle-handshake-errors branch from 8c8baa3 to d8a5ee3 Compare September 28, 2022 21:09
nbbeeken
nbbeeken previously approved these changes Sep 28, 2022
View reviewed changes
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Sep 28, 2022
nbbeeken
nbbeeken previously approved these changes Sep 29, 2022
View reviewed changes
baileympearson
baileympearson requested changes Sep 29, 2022
View reviewed changes
src/sdam/server.ts Outdated Show resolved Hide resolved
test/unit/sdam/server.test.ts Show resolved Hide resolved
@nbbeeken nbbeeken merged commit cbe7533 into main Sep 29, 2022
@nbbeeken nbbeeken deleted the NODE-4650/handle-handshake-errors branch September 29, 2022 18:33
ZLY201 pushed a commit to ZLY201/node-mongodb-native that referenced this pull request Nov 5, 2022
@dariakp @ZLY201
feat(NODE-4650): handle handshake errors with SDAM (mongodb#3426)
5a70e79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dariakp @nbbeeken @baileympearson