Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-5063): make DestroyOptions required on connection.destroy #3568

Merged
merged 2 commits into from
Feb 14, 2023
Merged

refactor(NODE-5063): make DestroyOptions required on connection.destroy #3568

merged 2 commits into from
Feb 14, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Feb 14, 2023 •
edited
Loading

Description

What is changing?

Applies all refactor changes from #3482. Specifically, this PR makes the DestroyOptions interface required.

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review February 14, 2023 22:53
@dariakp dariakp added Primary Review In Review with primary reviewer, not yet ready for team's eyes and removed wip labels Feb 14, 2023
@dariakp dariakp merged commit 666f01c into main Feb 14, 2023
@dariakp dariakp deleted the NODE-5063 branch February 14, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @dariakp