Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4854): set timeout on write and reset on message #3582

Merged
merged 20 commits into from
Mar 3, 2023
Merged

fix(NODE-4854): set timeout on write and reset on message #3582

merged 20 commits into from
Mar 3, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 28, 2023 •
edited
Loading

Description

What is changing?

The socket timeout:

  • Is not set on freshly created connections
  • Is set before writing to the socket
  • Is cleared when recieving a message

What is the motivation for this change?

Fixes a bug where connection in the pool were getting socket timeouts for being idle.

The commits are curated here to make reviewing the test changes easier, the file I worked in needed some TS love 💙 and some context blocks.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review February 28, 2023 23:47
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 1, 2023
baileympearson
baileympearson requested changes Mar 1, 2023
View reviewed changes
test/unit/cmap/connection.test.ts Show resolved Hide resolved
test/unit/cmap/connect.test.ts Outdated Show resolved Hide resolved
baileympearson
baileympearson requested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment - putting it in team review since it's small

test/unit/cmap/connection.test.ts Outdated Show resolved Hide resolved
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 2, 2023
baileympearson
baileympearson previously approved these changes Mar 2, 2023
View reviewed changes
@nbbeeken
Copy link
Contributor Author

nbbeeken commented Mar 2, 2023

Resolves NODE-2941

baileympearson
baileympearson requested changes Mar 2, 2023
View reviewed changes
test/unit/cmap/connect.test.ts Outdated Show resolved Hide resolved
test/unit/cmap/connect.test.ts Outdated Show resolved Hide resolved
dariakp
dariakp previously approved these changes Mar 2, 2023
View reviewed changes
baileympearson
baileympearson requested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing unit tests

@baileympearson baileympearson merged commit 4a7b5ec into main Mar 3, 2023
@baileympearson baileympearson deleted the NODE-4854-minPoolSizeReconnections branch March 3, 2023 17:59
@nbbeeken nbbeeken mentioned this pull request Mar 3, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@dariakp dariakp dariakp left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @baileympearson @dariakp