Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6066): signature can be optional at runtime #4069

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 4, 2024

Description

What is changing?

  • Correct typescript for signature property on ClusterTime interface
Is there new documentation needed for these changes?

No.. well yes, these are docs changes!

What is the motivation for this change?

Release Highlight

ClusterTime interface signature optionality

The ClusterTime interface incorrectly reported the signature field as required, the server may omit it, so the typescript has been updated to reflect reality.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson self-assigned this Apr 4, 2024
@baileympearson baileympearson merged commit ce55ca9 into main Apr 4, 2024
17 of 26 checks passed
@baileympearson baileympearson deleted the NODE-6066-signature branch April 4, 2024 21:13
baileympearson pushed a commit to baileympearson/node-mongodb-native that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants