Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-261305: Extend split e2e tests #100

Merged
merged 15 commits into from
Aug 9, 2024
Merged

CLOUDP-261305: Extend split e2e tests #100

merged 15 commits into from
Aug 9, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Jul 23, 2024

Proposed changes

Jira ticket: CLOUDP-261305

This PR does the following:

  1. Updates the dev and prod files with latest specs + new version
  2. Adds a test to check that splitting works and generates a valid spec for OASes that have external dependencies (api registry)
  3. Dynamically get the versions to avoid having them hardcoded

Core changes in tools/cli/test/e2e/cli/split_test.go

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Further comments

@andreaangiolillo
Copy link
Collaborator

PR #100!!! 💯 😮 🙀

@blva blva changed the title Add old versions back CLOUDP-261305: Extend split e2e tests Aug 9, 2024
@blva blva marked this pull request as ready for review August 9, 2024 16:21
@blva blva requested a review from a team as a code owner August 9, 2024 16:21
"2023-11-15",
"2024-05-30",
"2025-01-01",
var skipVersions = []string{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still working on adding these two versions in a next PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here #153

Comment on lines +128 to +130
if folder == "prod" && version == "2025-01-01" {
continue
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this to be if "prod" and date in the future?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! good point

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm opening another follow-up pr so I'll add this right away in #153

@blva blva merged commit 0e13226 into main Aug 9, 2024
9 checks passed
@blva blva deleted the CLOUDP-261305 branch August 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants