fix: FOAS Prod GH Action creates wrong issue #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Jul 31, 2024
| @@ -41,7 +42,7 @@ jobs: | |||
| npx -- @stoplight/spectral-cli@"${SPECTRAL_VERSION}" lint ./tmp/collection.json --ruleset=./validation/spectral.yaml | |||
| popd | |||
| - name: Create Issue | |||
| if: ${{ failure() }} | |||
| if: ${{ failure() && steps.spectral-validation.outcome == 'failure' }} | |||
There was a problem hiding this comment.
can you explain a bit how this fix the issue? (newbie)
There was a problem hiding this comment.
sure
failure() && steps.spectral-validation.outcome == 'failure'
failure() check if the overall GH action has failed.
steps.spectral-validation.outcome == 'failure' makes sure that the step with the id spectral-validation has failed
Only if both conditions are satisfied, the Create Issue step will run.
Before the fix, the only condition to create the issue was that the overall action has failed.
blva
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes a bug with the FOAS GH action that creates multiple issue when one step fails
fixes: #123