CLOUDP-26613: add normalization to the changelog #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Aug 7, 2024
| } | ||
|
|
||
| func (o *Opts) Run() error { | ||
| changelog, err := openapi.NewChangelog( |
There was a problem hiding this comment.
[nit] could we clean up test code and add e2e for the command?
There was a problem hiding this comment.
the command is not doing anything beside the normalization, if we add the e2e test now we will need to change it completely once the command create the actual changelog. I think we can wait for e2e tests since the command is not ready
blva
reviewed
Aug 7, 2024
blva
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-26613
This PR adds support for the first step of the API Changelog which is normalizing the input specs.