Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-266130: Add changelog core logic #143

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Aug 7, 2024

Proposed changes

Jira ticket: CLOUDP-266130

This PR adds changelog core logic to FOAS CLI

./bin/foascli changelog create -b ~/Downloads/test/base -r ~/Downloads/test/revision -e ~/Downloads/test/exceptions.yaml                         
Printing the checks
[
  {
    "Attributes": null,
    "Id": "api-schema-removed",
    "Args": [
      "AzureHardwareSpec20250101"
    ],
    "Comment": "",
    "Level": 3,
    "Component": "schemas",
    "SourceFile": "",
    "SourceLine": 0,
    "SourceLineEnd": 0,
    "SourceColumn": 0,
    "SourceColumnEnd": 0
  },
.....
]

@andreaangiolillo andreaangiolillo changed the title added changelo logic CLOUDP-266130: Add changelog core logic Aug 7, 2024
@andreaangiolillo andreaangiolillo marked this pull request as ready for review August 7, 2024 16:01
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner August 7, 2024 16:01
@andreaangiolillo andreaangiolillo merged commit 36307cb into main Aug 7, 2024
8 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-266130_add_changelog_logic branch August 7, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants