fix: fixes branded_preview.sh to run the version command with the correct branch name for prod + update readme with new badge
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
changed the title
andreaangiolillo
changed the title
branded_preview.sh to run the version command with the correct branch name for prod + update readme with new badge
andreaangiolillo
commented
Aug 9, 2024
Comment on lines
+4
to
+5
| foascli versions -s v2.json --env "${target_env:?}" -o versions.json | ||
|
|
There was a problem hiding this comment.
main fix, we were providing the env=main instead of prod, defaulting to dev
blva
approved these changes
Aug 9, 2024
andreaangiolillo
added a commit
that referenced
this pull request
Aug 9, 2024
…orrect branch name for prod + update readme with new badge (#152)
andreaangiolillo
added a commit
that referenced
this pull request
Aug 9, 2024
…orrect branch name for prod + update readme with new badge (#152)
andreaangiolillo
added a commit
that referenced
this pull request
Aug 9, 2024
…orrect branch name for prod + update readme with new badge (#152)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the
branded_preview.shto run the foascli version command with the correct branch name for prod. It also update the the readme.md with a badge opening the preview file.