Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the changelog create command to save changelog and changelog-all #167

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Aug 14, 2024

Proposed changes

This PR update the changelog create command to save the changelog and changelog-all files

./bin/foascli changelog create -b ~/Downloads/test/base -r ~/Downloads/test/revision -e ~/Downloads/test/exceptions.yaml

Changelog was saved in 'changelog.json'.

2024/08/14 11:56:49
Changelog was saved in 'changelog.yaml'.

2024/08/14 11:56:49
Changelog was saved in 'changelog-all.json'.

2024/08/14 11:56:49
Changelog was saved in 'changelog-all.yaml'

I downloaded the changelog and specs from evergreen patch and compared them with the one generated and they were the same

squasher func(map[string][]*OasDiffEntry) ([]*OasDiffEntry, error)
}

func newSquashHandlers() []handler {
Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to keep the order of the changes when we print the changelog to match the order of the changelog generated in evergreen

@andreaangiolillo andreaangiolillo marked this pull request as ready for review August 14, 2024 15:07
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner August 14, 2024 15:07
@andreaangiolillo andreaangiolillo merged commit b2a081f into main Aug 15, 2024
8 checks passed
@andreaangiolillo andreaangiolillo deleted the fix_changelog branch August 15, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants