Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-267267: Update changelog creation to use the exemption file #170

Merged
merged 28 commits into from
Aug 19, 2024

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Aug 15, 2024

Proposed changes

Jira ticket: CLOUDP-267267

This PR adds support for using the exemption file when generating the changelog.
I tested my PR by comparing the generated file with the ones in the following evergreen patch https://evergreen.mongodb.com/task/mms_v20240731_generate_changelog_GENERATE_CHANGELOG_66b48594effa6900076ccf6a_24_08_08_08_45_08

Base automatically changed from CLOUDP-266429_add_v to main August 15, 2024 15:32
@andreaangiolillo andreaangiolillo marked this pull request as ready for review August 19, 2024 11:35
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner August 19, 2024 11:35
"github.com/tufin/oasdiff/load"
)

func TestOpenApiSpecMethods(t *testing.T) {
loader := openapi.NewOpenAPI3().WithExcludedPrivatePaths()
spec, err := loader.CreateOpenAPISpecFromPath("../../../test/data/changelog/test_spec.json")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] can we capture the sha/branch of this file for history purposes? can be a comment!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same file we have in the mms-repo and it was manually generated . I will add this comment in the spec in a follow up PR. Thanks!

@andreaangiolillo andreaangiolillo merged commit 7d5f612 into main Aug 19, 2024
8 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-267267 branch August 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants