Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up up spectral duplicated file #249

Merged
merged 1 commit into from
Oct 10, 2024
Merged

chore: clean up up spectral duplicated file #249

merged 1 commit into from
Oct 10, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Oct 10, 2024

Proposed changes

Remove it now that we have pinned the sha in mms.

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Further comments

@blva blva marked this pull request as ready for review October 10, 2024 13:22
@blva blva requested a review from a team as a code owner October 10, 2024 13:22
Comment on lines -1 to -2
# https://meta.stoplight.io/docs/spectral/cb95cf0d26b83-core-functions
extends:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the spectral in mms still pointing to this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for checking! another question: is the GH action release updated already to use the new file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking yes since I updated in the previous PR and Spectral Lint Commited OpenAPI Spec is not failing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you did

run: npx -- @stoplight/spectral-cli@"${SPECTRAL_VERSION}" lint openapi-foas.yaml --ruleset=tools/spectral/.spectral.yaml
👍

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit 745b53c into main Oct 10, 2024
10 checks passed
@blva blva deleted the spectral-cleanup branch October 10, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants