Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-251170: The foas.json contains external references to the openapi-mms.json spec #43

Merged
merged 6 commits into from
May 29, 2024

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented May 29, 2024

Proposed changes

Jira ticket: CLOUDP-251170

The generate foas.json contains external references to openapi-mms.json components.
This PR updates the merging logic to remove openapi-mms.json from the path references.

Example of external reference:
$ref": "openapi-mms.json#/components/responses/internalServerError"

what we want in the foas.json is
$ref": "#/components/responses/internalServerError"

@andreaangiolillo andreaangiolillo marked this pull request as ready for review May 29, 2024 11:20
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner May 29, 2024 11:20
@andreaangiolillo andreaangiolillo merged commit cd23fbc into main May 29, 2024
6 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-251170 branch May 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants