-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-259458: Sort tags alphabetically #55
Conversation
assert.Equal(t, len(o.base.Spec.Tags), len(tc.expectedTags)) | ||
// check tag names are the same | ||
for i := range o.base.Spec.Tags { | ||
assert.Equal(t, o.base.Spec.Tags[i].Name, tc.expectedTags[i].Name) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't the following do the same? it should account for order
assert.Equal(t, len(o.base.Spec.Tags), len(tc.expectedTags)) | |
// check tag names are the same | |
for i := range o.base.Spec.Tags { | |
assert.Equal(t, o.base.Spec.Tags[i].Name, tc.expectedTags[i].Name) | |
} | |
assert.Equal(t, tc.expectedTags, o.base.Spec.Tags)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it doesn't work as it is a list of objects, it complains about the addresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Jira ticket: CLOUDP-259458
Checklist
Further comments