Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-261305: Add prod e2e tests #94

Merged
merged 7 commits into from
Jul 23, 2024
Merged

CLOUDP-261305: Add prod e2e tests #94

merged 7 commits into from
Jul 23, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Jul 22, 2024

Proposed changes

Jira ticket: CLOUDP-261305

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Further comments

@@ -14,8 +14,8 @@ import (
)

var versions = []string{
"2023-01-01",
"2023-02-01",
// "2023-01-01",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[need a follow-up PR]

The 2023-01-01 clusters endpoints dont show as deprecated in the current specs, and our logic is marking them as deprecated rightfully. Need to check w/ the team if we want to fix this os ir if was a desired behaviour.

All other items are matching.

@@ -113,7 +122,8 @@ func ValidateVersionedSpec(t *testing.T, correctSpecPath, generatedSpecPath stri
t.Helper()
correctSpec := newOpenAPISpec(t, correctSpecPath)
generatedSpec := newOpenAPISpec(t, generatedSpecPath)
d, err := diff.Get(diff.NewConfig(), correctSpec, generatedSpec)
examples := []string{"examples"}
d, err := diff.Get(diff.NewConfig().WithExcludeElements(examples), correctSpec, generatedSpec)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing examples because our generated spec is matching with the expected examples after we split, but the old ones are not, so I'll ignore for now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a comment with the explanation so that we don't forget about it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes will add in the follow-up PR!

@blva blva marked this pull request as ready for review July 23, 2024 12:43
@blva blva requested a review from a team as a code owner July 23, 2024 12:43
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit e47b3d0 into main Jul 23, 2024
7 checks passed
@blva blva deleted the CLOUDP-261305 branch July 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants