CLOUDP-261305: Add prod e2e tests #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
commented
Jul 23, 2024
| @@ -14,8 +14,8 @@ import ( | |||
| ) | |||
|
|
|||
| var versions = []string{ | |||
| "2023-01-01", | |||
| "2023-02-01", | |||
| // "2023-01-01", | |||
There was a problem hiding this comment.
[need a follow-up PR]
The 2023-01-01 clusters endpoints dont show as deprecated in the current specs, and our logic is marking them as deprecated rightfully. Need to check w/ the team if we want to fix this os ir if was a desired behaviour.
All other items are matching.
blva
commented
Jul 23, 2024
| @@ -113,7 +122,8 @@ func ValidateVersionedSpec(t *testing.T, correctSpecPath, generatedSpecPath stri | |||
| t.Helper() | |||
| correctSpec := newOpenAPISpec(t, correctSpecPath) | |||
| generatedSpec := newOpenAPISpec(t, generatedSpecPath) | |||
| d, err := diff.Get(diff.NewConfig(), correctSpec, generatedSpec) | |||
| examples := []string{"examples"} | |||
| d, err := diff.Get(diff.NewConfig().WithExcludeElements(examples), correctSpec, generatedSpec) | |||
There was a problem hiding this comment.
removing examples because our generated spec is matching with the expected examples after we split, but the old ones are not, so I'll ignore for now.
There was a problem hiding this comment.
could you add a comment with the explanation so that we don't forget about it?
There was a problem hiding this comment.
yes will add in the follow-up PR!
wtrocki
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-261305
Checklist
Further comments