DOP-4333: Limit search fetches to SearchResults component #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seungpark
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4333
Current Behavior:
Open the network tab of the browser's dev tools, filter by "search-transport" and you should see requests for them, even on pages that aren't the search page. The search page is expected to have them.
Server prod
Landing prod - homepage
Landing prod - search
Landing staging - search (facets enabled)
Staging Links:
Open the network tab of the browser's dev tools, filter by "search-transport" and you should see requests for them only on the search pages, and no requests on non-search pages. Ideally, this PR does not change the search page's current behavior.
Server staging
Landing staging - homepage
Landing staging - search (no facets)
Landing staging - search (with facets)
Notes:
SearchWrappercomponent was created to wrapSearchResultsso that we can move theSearchContextProvideraway fromRootProvider. This will allow the existingSearchResultscomponent to pull in search data from context without any major refactoring.Headercomponent. This was once used for contextual search across different docs sites, but since this functionality was removed from DOP-4105, it should be safe to remove now without any negative regression. We should consider re-adding if contextual search needs to be re-enabled.