Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ DOP-4358 pull out some functions into its own utils to be reused, along with creating a currentUserCleanup function #1009

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

caesarbell
Copy link
Collaborator

Stories/Links:

DOP-4358

Current Behavior:

Put a link to current staging or production behavior, if applicable

Staging Links:

Put a link to your staging environment(s), if applicable

Notes:

This logic focuses on the following

  • Pulls out localStorage removal logic into its own utils method, so it can be reused in other places.
  • Defined and implemented a cleanUsersCleanup method for browsers that contain more than 10 realm users in their localStorage.

There is no staging link provided in this PR, as it wouldn't provide much value for testing.

…along with creating a currentUserCleanup function
src/utils/realm-user-management.js Outdated Show resolved Hide resolved
src/utils/realm.js Outdated Show resolved Hide resolved
src/utils/realm.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it looks like it successfully removes extra users

@caesarbell caesarbell merged commit c4f12a4 into main Feb 13, 2024
4 checks passed
@caesarbell caesarbell deleted the DOP-4358 branch February 13, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants