DOP 4340/1: Homepage Redesign #1016
Conversation
mayaraman19
requested review from
schmalliso,
seungpark,
mmeigs and
anabellabuckvar
There was a problem hiding this comment.
minor comments below but overall looks great!
one minor thing i noticed is that the hero and text are not aligned very well. we set the height of the hero at different viewports and the align-self: end properties on the heading and paragraph make the margins vary when changing viewport.
for example:
we can take this in another issue, but perhaps we can make the hero image as a background-image property and have strict margins, not alignments, on the heading and paragraph elements.
|
I think I have addressed the comments - as for the header, this got approved by design, we didn't want to touch too many things in case the homepage gets changed again but I'm happy to create a separate ticket because I do think having set margins would be nice. |
| flex-direction: row; | ||
| padding-left: ${theme.size.medium}; | ||
| img { | ||
| width: ${theme.size.xlarge}; |
There was a problem hiding this comment.
this overrides the width for the first set of cards, but on a minor note, the second icons seem smaller than design as well (design shows roughly 42-46px width):
Stories/Links:
DOP-4340 + DOP-4341 + DOP-4342 + other small tweaks
New homepage! Now including @anabellabuckvar's tweaks to the introduction header. Built off of this branch of
docs-landing.Staging Links:
Updated staging link
Figma
Notes:
README updates