DOP-4443: Remove GATSBY_SHOW_CHATBOT feature flag from the frontend #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayaraman19
changed the title
anabellabuckvar
approved these changes
Mar 13, 2024
|
I'm not sure I see the awkward gap, but I think you should reach out to design quickly with two screenshots and see what they say! Would be a quick fix to add to this PR. |
|
Going to file an extra ticket for the gap fix since it is a little more complicated than originally thought. |
mmeigs
approved these changes
Mar 14, 2024
|
Reminder to remove these feature flag env vars from AWS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4443
Current Behavior:
Currently, while the chatbot is visible in production, in other environments the
GATSBY_SHOW_CHATBOTenvironment variable needs to be true for the chatbot to show up. This PR removes the need for that!Staging Links:
Cloud docs staging
Docs landing staging
Notes:
This is a tiny, tiny issue but I noticed that when the chatbot is shown, there's a larger, somewhat more awkward (in my opinion) gap under the "View All Products" drop down in the Sidenav (no-chatbot staging link here). I'm wondering if that's something that should be changed? Happy to leave it or check with design.
README updates