Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4470: Bump LG search-input version to fix localized input #1044

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented Mar 19, 2024

Stories/Links:

DOP-4470

Current Behavior:

Prod search page - typing "유" results in its individual characters being used as input "ㅇㅠ"
Staging search page - on the main branch, to confirm that this isn't only happening in prod

Staging Links:

Staging search page - typing "유" results in "유"

Notes:

  • The fix was to just bump the @leafygreen-ui/search-input package to its latest version. Couldn't figure out why this fixed it, but I'm assuming there was just some sort of incompatibility in our version.
  • To test locally, you may need to add Korean as a language on your keyboard. I also checked in with both Hyejin and Ryan from MongoDB, who are helping out with translations for Korean and Simplified Chinese respectively, and they said the input in the staging link was working as expected.
  • Since the search results are currently in English, input in different languages may not have any available search results in the staging link. Search results will need to be validated in production since Smartling handles translations

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@rayangler rayangler changed the title DOP-4470: Bump LG search-input version to fix input in different lang… DOP-4470: Bump LG search-input version to fix localized input Mar 19, 2024
@rayangler rayangler marked this pull request as ready for review March 19, 2024 18:20
Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to understand, but I think I see it.

@rayangler
Copy link
Collaborator Author

Yeah, when I have time, I'll try to see if I can find an obvious root cause, but it's good to see that it works okay after the version bump. Let me know if I can answer any further questions about this change since it's pretty random!

@rayangler rayangler merged commit 232eba8 into main Mar 19, 2024
4 checks passed
@rayangler rayangler deleted the DOP-4470 branch March 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants