Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4601: Unhide Japanese locale #1250

Merged
merged 5 commits into from
Sep 24, 2024
Merged

DOP-4601: Unhide Japanese locale #1250

merged 5 commits into from
Sep 24, 2024

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented Sep 23, 2024

Stories/Links:

DOP-4601

Current Behavior:

Staging Links:

All links were built without the GATSBY_FEATURE_SHOW_HIDDEN_LOCALES feature flag, to mimic prod.

Notes:

  • Japanese should now be present in consistent nav language dropdowns (top nav and footer)
  • Users with a browser language set to Japanese (without previously selecting the English language) will now be redirected to the Japanese site.
  • Small change to include hidden sites in locale validation. This is irrelevant now, but it would've been useful so that any locale-specific logic on a hidden site like ja-jp would've seen ja-jp as valid. If done previously, this would've helped prevent bugs where hreflang links on the Japanese docs site were showing ja-jp in the URLs, or showing the chatbot as an option.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for mongodb-snooty ready!

Name Link
🔨 Latest commit d69e83c
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-snooty/deploys/66f31855a73ca800086822e9
😎 Deploy Preview https://deploy-preview-1250--mongodb-snooty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rayangler rayangler marked this pull request as ready for review September 23, 2024 18:25
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting how noto-sans-sc and noto-sans-jp look almost identical!

@rayangler
Copy link
Collaborator Author

Interesting how noto-sans-sc and noto-sans-jp look almost identical!

Yup, they're pretty similar given that they're from a similar font family. I think the main difference is in whether a glyph/character is present in the font or not

@rayangler rayangler merged commit 95c523a into main Sep 24, 2024
8 checks passed
@rayangler rayangler deleted the DOP-4601-jp-live branch September 24, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants