Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5014: allow chatbot option consecutively #1281

Merged
merged 2 commits into from
Oct 16, 2024
Merged

DOP-5014: allow chatbot option consecutively #1281

merged 2 commits into from
Oct 16, 2024

Conversation

seungpark
Copy link
Collaborator

Stories/Links:

DOP-5014

Current Behavior:

Current behavior on docs shows that you cannot choose chatbot twice in a row

Screen.Recording.2024-10-16.at.9.34.52.AM.mov

Staging Links:

Staging link with minimal changes
Above link works with multiple times of selecting the chatbot option

Notes:

  • This was due not triggering the useEffect watching for changes on selectedOption, because selectedOption was persisted as the same option. This small PR resets the selectedOption when any option is selected, to enable the trigger.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for mongodb-snooty ready!

Name Link
🔨 Latest commit 6d42af1
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-snooty/deploys/670fcf3853f67900088fa59c
😎 Deploy Preview https://deploy-preview-1281--mongodb-snooty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seungpark seungpark requested a review from mmeigs October 16, 2024 13:53
Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seungpark seungpark merged commit b5408e1 into main Oct 16, 2024
6 of 8 checks passed
@seungpark seungpark deleted the DOP-5014 branch October 16, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants