Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5053: Fix client-side fetch refresh - legacy page #1283

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Oct 17, 2024

Stories/Links:

DOP-5053

Current Behavior:

Current

Staging Links:

Staging

Notes:

Fixes error in checking for empty fetch result. Fixes and adds a test.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for mongodb-snooty ready!

Name Link
🔨 Latest commit 94d3bdd
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-snooty/deploys/6712b4665cdbf40008ec52c7
😎 Deploy Preview https://deploy-preview-1283--mongodb-snooty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main change looks good! Just realized something with the tests

tests/unit/DeprecatedVersionSelector.test.js Outdated Show resolved Hide resolved
tests/unit/DeprecatedVersionSelector.test.js Outdated Show resolved Hide resolved
@mmeigs mmeigs requested a review from rayangler October 18, 2024 19:29
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@mmeigs mmeigs merged commit df17bc3 into main Oct 18, 2024
6 of 8 checks passed
@mmeigs mmeigs deleted the DOP-5053-legacy-fetch branch October 18, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants