-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-5052: fixing link buffer's on mobile #1289
Conversation
✅ Deploy Preview for mongodb-snooty ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments below!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor points: 1) can we update the docstheme so that navbar has more buffer space (dont need to add another, but we can increase the existing)
and 2) update the staging link pls! it is still on an old commit
otherwise LGTM !
@seungpark , changed the offset to be 95px but let me know if you want something different, staging links should work now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM!
Stories/Links:
DOP-5052
Current Behavior:
Staging Links:
merge page
replSetGetStatus page
definition list item staging
Notes:
banner-dev
and it seemed to work without changing any of the values, but feel free to check yourselfREADME updates