Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4810: All Products dropdown docs-qa links #1300

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Oct 31, 2024

Stories/Links:

DOP-4810

Current Behavior:

I just staged this branch... but clicking on any of the products would take you to something like www.mongodb.com.website/atlas

Staging Links:

Preprd landing
Might be staged back by someone else to how it used to be (buggy)

Pictures of hovered urls
Screenshot 2024-10-31 at 4 21 18 PM
Screenshot 2024-10-31 at 4 21 27 PM

Notes:

Went for the simplest approach. Modifying baseUrl util would have had wider ranging consequences.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for mongodb-snooty ready!

Name Link
🔨 Latest commit ae9959f
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-snooty/deploys/6729208080c6670008a39d6f
😎 Deploy Preview https://deploy-preview-1300--mongodb-snooty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

plugins/utils/products.js Outdated Show resolved Hide resolved
@mmeigs mmeigs requested a review from rayangler November 4, 2024 19:30
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love not needing baseUrl()!

@mmeigs mmeigs merged commit 89cc8e1 into main Nov 4, 2024
6 checks passed
@mmeigs mmeigs deleted the DOP-4810-staging-products branch November 4, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants