Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-632: Render options #164

Merged
merged 2 commits into from
Mar 20, 2020
Merged

DOP-632: Render options #164

merged 2 commits into from
Mar 20, 2020

Conversation

sophstad
Copy link
Member

[JIRA] [Ecosystem Staging] [BI Connector Staging]

  • Correctly render targets:
    • If present, render the directive argument with target ID attached.
    • Otherwise, render empty <span> tags.
  • Added snapshot test to verify both cases above
  • Simplified Literal component in order to correctly render dictionary lists associated with targets.

Test notes

  • Provided staging link to a BI Connector page that has heavy use of :option:

@sophstad sophstad requested a review from i80and March 19, 2020 16:33
i80and
i80and approved these changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@i80and i80and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sophstad sophstad merged commit fcd83ca into master Mar 20, 2020
@sophstad sophstad deleted the DOP-632 branch March 20, 2020 16:44
@sophstad sophstad mentioned this pull request Mar 23, 2020
Merged
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
@sophstad
DOP-632: Render options (#164)
5341ed2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i80and i80and i80and approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophstad @i80and