DOP-873: Fix sidebar/left navtab on-load flashing #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOP-873.
The Bug
During the pre-render phase, the window size is
undefined
. This caused cascading effects in which theshowLeftColumn
state wasfalse
during pre-render. Then, on load, the left column would briefly flash closed before opening. To fix, we add an!isBrowser()
check to the logic to ensure that all elements are pre-rendered. During pre-render, the CSS behavior is defined by mongodb-base.css. Post-render, the styles innavigation.module.css
now have an additionalpostRender
class such thatshowNav.postRender
andleft-column.postRender
allow React'stoggleLeftColumn()
behavior.Staging