DOP-3848: render H2 component as h1, H3 component as h2 #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayaraman19
changed the title
mmeigs
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
[DOP-3848](https://jira.mongodb.org/browse/DOP-3848
Current Behavior:
The Changelog page currently renders the title as h2, and the release dates as h3. This PR has changed them to retain the style and keep using the H2 and H3 LeafyGreen components, but they are now rendered as h1 and h2, respectively.
Staging link:
https://docs-mongodb-org-stg.s3.us-east-2.amazonaws.com/master/cloud-docs/maya/dop-3848/reference/api-resources-spec/changelog/
Notes:
There was a bit of confusion between retaining/not retaining the styles of an H1 vs H2 component, or H2 vs H3 component, and I'm still not completely sure what to go with but this is going with retaining the original style of the webpage