-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4282: Implement container for lab drawers #992
Conversation
LGTM once DOP-4280 is pulled in! It's been merged |
src/components/Instruqt/index.js
Outdated
{process.env.GATSBY_FEATURE_LAB_DRAWER === 'true' ? ( | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might also want to import and use the hasLab
variable from InstruqtContext as part of the conditional here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, for sure. Forgot that from the context merge. Thanks for catching!
Stories/Links:
DOP-4282
Current Behavior:
Server prod
Staging Links:
Server staging with drawer - notable difference is that the lab opens in a drawer instead of as part of the docs content.
Server staging without drawer
Notes:
Any merge conflicts will need to be sorted out to be compatible with DOP-4280: Create React context to manage Instruqt lab state #989, once it is merged.