Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4282: Implement container for lab drawers #992

Merged
merged 10 commits into from
Jan 29, 2024
Merged

DOP-4282: Implement container for lab drawers #992

merged 10 commits into from
Jan 29, 2024

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented Jan 25, 2024

Stories/Links:

DOP-4282

Current Behavior:

Server prod

Staging Links:

Server staging with drawer - notable difference is that the lab opens in a drawer instead of as part of the docs content.
Server staging without drawer

Notes:

  • The purpose of this PR is to create a component that renders the Instruqt lab in a drawer. Finalized styling for the lab title and the lab buttons are excluded and will be addressed as part of DOP-4283.
  • Since the interactive lab button does not exist next to the page heading yet, the drawer will be shown in place of the embedded Instruqt lab as long as the feature flag is turned on. This will be reconciled as part of a future PR.
  • Any merge conflicts will need to be sorted out to be compatible with DOP-4280: Create React context to manage Instruqt lab state #989, once it is merged.

@rayangler rayangler marked this pull request as ready for review January 25, 2024 19:30
@anabellabuckvar
Copy link
Collaborator

anabellabuckvar commented Jan 26, 2024

LGTM once DOP-4280 is pulled in! It's been merged

Comment on lines 50 to 51
{process.env.GATSBY_FEATURE_LAB_DRAWER === 'true' ? (
<>
Copy link
Collaborator

@anabellabuckvar anabellabuckvar Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might also want to import and use the hasLab variable from InstruqtContext as part of the conditional here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, for sure. Forgot that from the context merge. Thanks for catching!

@rayangler rayangler merged commit 5624334 into master Jan 29, 2024
2 checks passed
@rayangler rayangler deleted the DOP-4282 branch January 29, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants