-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-4296: add portuguese and korean to language selector #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to verify, are there any stage sites that include the language flipped?
@@ -121,8 +121,10 @@ const DocumentBody = (props) => { | |||
const slugForUrl = slug === '/' ? `${withPrefix('')}` : `${withPrefix(slug)}`; // handle the `/` path | |||
const onSelectLocale = (locale) => { | |||
const localeHrefMap = { | |||
'zh-cn': `https://mongodbcom-cdn.staging.corp.mongodb.com/zh-cn${slugForUrl}/`, | |||
'en-us': `https://mongodbcom-cdn.website.staging.corp.mongodb.com${slugForUrl}/`, | |||
'zh-cn': `${location.origin}/zh-cn${slugForUrl}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use the util function assertTrailingSlash
to validate trailing slashes for parts / slug here
I am working on that now. Before moving this from Draft, there will be a staging link showcasing the language flipper. |
Just to confirm you are not talking about the stage commits correct, we are talking about seeing this on a |
yup. just wanted to confirm this is the correct path (in diff environments). i think we had a view of this before? |
We now have the |
Stories/Links:
DOP-4296
Current Behavior:
Production
DOP-4295 Stage Link
Staging Links:
Staged Link
Notes:
This PR adds two additional languages to the language flipper, i.e. Korean and Portuguese.