Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4296: add portuguese and korean to language selector #996

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Conversation

caesarbell
Copy link
Collaborator

Stories/Links:

DOP-4296

Current Behavior:

Production
DOP-4295 Stage Link

Staging Links:

Staged Link

Notes:

This PR adds two additional languages to the language flipper, i.e. Korean and Portuguese.

@schmalliso schmalliso changed the title Dop 4296 DOP-4296: add portuguese and korean to language selector Jan 30, 2024
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to verify, are there any stage sites that include the language flipped?

@@ -121,8 +121,10 @@ const DocumentBody = (props) => {
const slugForUrl = slug === '/' ? `${withPrefix('')}` : `${withPrefix(slug)}`; // handle the `/` path
const onSelectLocale = (locale) => {
const localeHrefMap = {
'zh-cn': `https://mongodbcom-cdn.staging.corp.mongodb.com/zh-cn${slugForUrl}/`,
'en-us': `https://mongodbcom-cdn.website.staging.corp.mongodb.com${slugForUrl}/`,
'zh-cn': `${location.origin}/zh-cn${slugForUrl}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use the util function assertTrailingSlash to validate trailing slashes for parts / slug here

@caesarbell
Copy link
Collaborator Author

to verify, are there any stage sites that include the language flipped?

I am working on that now. Before moving this from Draft, there will be a staging link showcasing the language flipper.

@caesarbell
Copy link
Collaborator Author

Staged Link

Just to confirm you are not talking about the stage commits correct, we are talking about seeing this on a pre-prd env?

@seungpark
Copy link
Collaborator

Staged Link

Just to confirm you are not talking about the stage commits correct, we are talking about seeing this on a pre-prd env?

yup. just wanted to confirm this is the correct path (in diff environments). i think we had a view of this before?

@caesarbell
Copy link
Collaborator Author

Staged Link

Just to confirm you are not talking about the stage commits correct, we are talking about seeing this on a pre-prd env?

yup. just wanted to confirm this is the correct path (in diff environments). i think we had a view of this before?

We can view it here for the work done in DOP-4295

@caesarbell caesarbell marked this pull request as ready for review February 2, 2024 21:47
@caesarbell
Copy link
Collaborator Author

We now have the pre-prd deployed with the changes from this PR

@caesarbell caesarbell merged commit f222623 into main Feb 5, 2024
2 checks passed
@caesarbell caesarbell deleted the DOP-4296 branch February 5, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants