Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2310 Include encryptFields in expected FLE2 test command #1205

Merged
merged 3 commits into from
May 3, 2022
Merged

DRIVERS-2310 Include encryptFields in expected FLE2 test command #1205

merged 3 commits into from
May 3, 2022

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented May 3, 2022

In the “CreateCollection from encryptedFieldsMap”, it makes sense
to also assert on the encryptedFields option that ends up being
passed to the server.

Please complete the following before merging:

  • Bump spec version and last modified date.
  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@addaleax
DRIVERS-2310 Include encryptFields in expected FLE2 test command
a1cd02b 
In the “CreateCollection from encryptedFieldsMap”, it makes sense
to also assert on the encryptedFields option that ends up being
passed to the server.
@addaleax addaleax requested a review from a team as a code owner May 3, 2022 16:48
@addaleax addaleax requested review from kevinAlbs and removed request for a team May 3, 2022 16:48
@addaleax addaleax mentioned this pull request May 3, 2022
Merged
5 tasks
kevinAlbs
kevinAlbs reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. Thank you for the PR!

source/client-side-encryption/tests/fle2-CreateCollection.yml Outdated Show resolved Hide resolved
kevinAlbs
kevinAlbs approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and passes in Go driver. Thank you!

@kevinAlbs kevinAlbs merged commit 41a9aed into mongodb:master May 3, 2022
@addaleax addaleax deleted the 2310-dev branch May 9, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @kevinAlbs