Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2412: add pre 6.0 condition to stale primary logic #1309

Merged
merged 5 commits into from
Oct 3, 2022
Merged

DRIVERS-2412: add pre 6.0 condition to stale primary logic #1309

merged 5 commits into from
Oct 3, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Sep 28, 2022 •
edited
Loading

Maintain updateRSFromPrimary behavior on pre 6.0 servers for electionId/setVersion checking. And include tests from before the change.

Please complete the following before merging:

@nbbeeken nbbeeken force-pushed the DRIVERS-2412-electionId-setVersion-pre6 branch from 840edfb to 3a383b5 Compare September 29, 2022 19:15
@nbbeeken nbbeeken changed the title [WIP] DRIVERS-2412: add pre 6.0 condition to stale primary logic DRIVERS-2412: add pre 6.0 condition to stale primary logic Sep 29, 2022
@nbbeeken nbbeeken marked this pull request as ready for review September 29, 2022 19:17
@nbbeeken nbbeeken requested a review from a team as a code owner September 29, 2022 19:17
@nbbeeken nbbeeken requested review from ShaneHarvey and removed request for a team September 29, 2022 19:17
@nbbeeken nbbeeken mentioned this pull request Sep 29, 2022
Merged
5 tasks
ShaneHarvey
ShaneHarvey requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally and have a patch running to confirm here: https://spruce.mongodb.com/version/63362b4b850e610d084de99a/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Could you add a changelog entry as well?

source/server-discovery-and-monitoring/server-discovery-and-monitoring.rst Outdated Show resolved Hide resolved
source/server-discovery-and-monitoring/server-discovery-and-monitoring.rst Outdated Show resolved Hide resolved
source/server-discovery-and-monitoring/server-discovery-and-monitoring.rst Outdated Show resolved Hide resolved
source/server-discovery-and-monitoring/server-discovery-and-monitoring.rst Outdated Show resolved Hide resolved
ShaneHarvey
ShaneHarvey requested changes Sep 30, 2022
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments otherwise LGTM.

source/server-discovery-and-monitoring/server-discovery-and-monitoring.rst Outdated Show resolved Hide resolved
source/server-discovery-and-monitoring/server-discovery-and-monitoring.rst Outdated Show resolved Hide resolved
ShaneHarvey
ShaneHarvey approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@nbbeeken nbbeeken merged commit 37c32cf into master Oct 3, 2022
@nbbeeken nbbeeken deleted the DRIVERS-2412-electionId-setVersion-pre6 branch October 3, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @ShaneHarvey