DRIVERS-2091: remove references to getLastError #1698
Conversation
W-A-James
changed the title
source/driver-bulk-update.rst
Outdated
There was a problem hiding this comment.
Note: removed since everything in this document seemed to pertain to behaviour that was current in versions <= 2.6
There was a problem hiding this comment.
I suggest we add this back and open a new drivers ticket to remove this spec.
W-A-James
requested review from
nbbeeken and
dariakp
and removed request for
a team
source/driver-bulk-update.rst
Outdated
There was a problem hiding this comment.
I suggest we add this back and open a new drivers ticket to remove this spec.
| 3. On ServerVersion less than 2.6, drivers MUST NOT send a getLastError command for an Unacknowledged write concern. | ||
| 4. FindAndModify helper methods MUST NOT send a write concern when the MaxWireVersion is less than 4. | ||
| 5. Helper methods for other commands that write MUST NOT send a write concern when the MaxWireVersion is less than 5. | ||
| 2. Commands supporting a write concern MUST send any non-default acknowledged write concern to the server in the |
There was a problem hiding this comment.
non-default acknowledged write concern -> non-default write concern. Unack'd writeConcerns need to be sent to the server too.
| 5. Helper methods for other commands that write MUST NOT send a write concern when the MaxWireVersion is less than 5. | ||
| 2. Commands supporting a write concern MUST send any non-default acknowledged write concern to the server in the | ||
| command. | ||
| 3. FindAndModify helper methods MUST NOT send a write concern when the MaxWireVersion is less than 4. |
There was a problem hiding this comment.
We can remove this since all drivers have dropped support for wire version <=4. 7 is the current min.
| 2. Commands supporting a write concern MUST send any non-default acknowledged write concern to the server in the | ||
| command. | ||
| 3. FindAndModify helper methods MUST NOT send a write concern when the MaxWireVersion is less than 4. | ||
| 4. Helper methods for other commands that write MUST NOT send a write concern when the MaxWireVersion is less than 5. |
There was a problem hiding this comment.
We can remove this for the same reason.
source/server-discovery-and-monitoring/server-discovery-and-monitoring.md
Outdated
Show resolved
Hide resolved
|
Merging, will file ticket to remove driver-bulk-update spec |
Please complete the following before merging:
clusters, and serverless).