Make getMongoData.js compatible with mongosh #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mongosh doesn't include the native hostname() method anymore * to make getMongoData.js compatible with mongosh check if hostname() method exists * if not, put "N/A"
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
getMongoData/getMongoData.js
Outdated
| @@ -263,7 +263,7 @@ function printInfo(message, command, section, printCapture, commandParameters) { | |||
| function printServerInfo() { | |||
| section = "server_info"; | |||
| printInfo('Shell version', version, section); | |||
| printInfo('Shell hostname', hostname, section); | |||
| printInfo('Shell hostname', typeof hostname !== "undefined" ? hostname : function(){return "N/A"}, section); | |||
There was a problem hiding this comment.
instead of returning N/A mongosh supports os.hostname()
getMongoData/getMongoData.js
Outdated
| @@ -580,7 +580,7 @@ if (! _printJSON) { | |||
| print("getMongoData.js version " + _version); | |||
| print("================================"); | |||
| } | |||
| var _host = hostname(); | |||
| var _host = typeof hostname !== "undefined" ? hostname() : "N/A"; | |||
There was a problem hiding this comment.
same here we should use os.hostname()
* Use os.hostname instead of "N/A" for shell hostname * Use db.printSecondaryReplicationInfo() instead of db.printSlaveReplicationInfo() if printSlaveReplicationInfo is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mongoshdoesn't include the native methodhostname()anymore and deprecated db.printSlaveReplicationInfo()