Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imageinfo - add more constructors #2159

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Imageinfo - add more constructors #2159

wants to merge 4 commits into from

Conversation

mgood7123
Copy link
Contributor

@mgood7123 mgood7123 commented Jul 9, 2022 •
edited by mattleibow
Loading

Description of Change

Adds some more ctor overloads.

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mgood7123 mgood7123 changed the title Imageinfo Imageinfo - add more constructors Jul 9, 2022
mattleibow
mattleibow reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, just seems to be one dodgy ctor... Thanks!

binding/Binding/SKImageInfo.cs Outdated Show resolved Hide resolved
@mgood7123
Copy link
Contributor Author

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattleibow mattleibow mattleibow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgood7123 @mattleibow