-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[System] Guard against attempting to creating out-of-range spans in m… #16049
Conversation
9fb3c0f
to
195860c
Compare
Should we upstream the fix? |
@marek-safar Since this is intended to fix a crash in VSM, can we move this through and consider upstreaming separate? |
@monojenkins build failed |
Yes but I am not sure it's the right fix if CoreFX is not experiencing the same crash |
@marek-safar @steveisok I brought this to upstream attention here: https://github.com/dotnet/corefx/issues/40054 - they don't have an issue reported of this same problem. There is no opinion so far. I should add a check that these event paths start with |
Is CoreFX actively testing against Catalina? All but a few cases of the crash are happening there. |
d746087
to
b4a8d23
Compare
@monojenkins build failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. All that needs done is to resolve the corefx conflict.
…acOS FileSystemWatcher
@monojenkins backport 2019-06 |
@monojenkins backport 2019-08 |
@steveisok backporting to 2019-06 failed, the patch results in conflicts:
Please backport manually! |
@steveisok backporting to 2019-08 failed, the patch results in conflicts:
Please backport manually! |
Failures in |
…spans in macOS FileSystemWatcher Bump to mono/corefx@545a4a5 Backport of mono#16049
…spans in macOS FileSystemWatcher Bump to mono/corefx@545a4a5 Backport of #16049
…acOS FileSystemWatcher
Should fix #15575