Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use githubLicenses for the latest_result.txt output #228

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

skw398
Copy link

@skw398 skw398 commented Apr 17, 2024

Background

Currently, githubLibraries list of PlistInfo is used for the latest_result.txt output. githubLibraries is the list before loading GitHub licenses. As a result, libraries whose licenses failed to load are also written to latest_result.txt.

This causes issues such as GitHub licenses not being reloaded even if there are licenses that failed to load, because there is no diff between the latest latest_result.txt and the one that was completely loaded before.

Solution

I've made the following changes:

  • The latest_result.txt output now uses githubLicenses instead of githubLibraries.
  • The assignment to the summary property is now executed in the collectLicenseInfos function rather than in compareWithLatestSummary.

The output format remains unchanged, as it still uses the library property description of GitHubLicense type, which is the same GitHub type as before.

Thank you.

@mono0926 mono0926 self-requested a review April 19, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant