Skip to content

Commit

Permalink
fix: remove redundant update of a message status
Browse files Browse the repository at this point in the history
  • Loading branch information
splaunov committed Jan 25, 2022
1 parent 36c2bb2 commit 6590f0a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
8 changes: 0 additions & 8 deletions courier/sms.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,5 @@ func (c *courier) dispatchSMS(ctx context.Context, msg Message) error {
return errors.New(http.StatusText(res.StatusCode))
}

if err := c.deps.CourierPersister().SetMessageStatus(ctx, msg.ID, MessageStatusSent); err != nil {
c.deps.Logger().
WithError(err).
WithField("message_id", msg.ID).
Error(`Unable to set the message status to "sent".`)
return err
}

return nil
}
8 changes: 0 additions & 8 deletions courier/smtp.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,14 +169,6 @@ func (c *courier) dispatchEmail(ctx context.Context, msg Message) error {
return errors.WithStack(err)
}

if err := c.deps.CourierPersister().SetMessageStatus(ctx, msg.ID, MessageStatusSent); err != nil {
c.deps.Logger().
WithError(err).
WithField("message_id", msg.ID).
Error(`Unable to set the message status to "sent".`)
return err
}

c.deps.Logger().
WithField("message_id", msg.ID).
WithField("message_type", msg.Type).
Expand Down

0 comments on commit 6590f0a

Please sign in to comment.