-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't refresh AuthenticatedAt for pin login (PS-333) #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Make sure all tests pass with the command:
go test -p 1 -tags sqlite,json1 -count=1 -failfast -timeout 30m ./...
Thanks, there are some test failed, but not sure if it is my environment issue, do you know the failures?
|
Try to pull hydra with this command before running tests
|
b88d0fb
to
302c013
Compare
Thanks, the tests passed. |
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments