Improve the 'testing' part of the peer review checklist #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying devdocs with
|
| Latest commit: |
0ffa4f7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a9812d4.devdocs-68g.pages.dev |
| Branch Preview URL: | https://timhunt-pr-checklist.devdocs-68g.pages.dev |
(verifying is correct!)
⚡️ Lighthouse report for the deploy preview of this PR
|
sarjona
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Hi @timhunt!
Thanks a lot for working on this improvement. I totally agree with all the points you addressed/improved so I'm more than happy to approve it :-)
Besides, it also opens the door to mention here that Generator tool can be used for manual tests, to make easier to setup testing scenario ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edit is in response to having to keep saying the same thing about changes that have come to me to CLR, after someone claims to have peer reviewed them. I hope this is not too opinionated.